-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenRC service and support for more inits #368
Conversation
capitalized an uncapitalized letter so that the capitalization would be consistent :)
fixed spelling
i am still trying to get this branch working on gentoo.
|
Weird.. if it's running openrc it should run fine since it's the exact same init and afaik it's the same structure. |
@WNCRY Did you manage to get it working? |
This doesn't seem to be working for me either. But I did get a script together that seemed to work for me. Also I don't know if this a case specific issue (I am testing on artix linux) but I will start on tty2, no matter what the script does. So it might just be best to use tty2 (It might also be useful to note that the systemd service file uses tty2). I made a fork with my version of the script feel free to just steal it for this PR. I did use this script from pspiagicw to start out because it worked somewhat. |
The script only starts ly in the provided tty, it's ly that's teleporting you to tty2, try to edit the I'm using tty7 because i thought it's easier, for the 1-6 ones you have to disable the
Yeah, that's fine i guess.
pspiagicw's script clogs up openrc-run which introduces a lot of issues, read my issue here where i |
I see now! I'm thinking this should be mentioned in the documentation. Although this could be intuited, some users may not. |
Fixed typo in ly call.
Yeah. Nice script, i'll try it out but i'm pretty sure it works.
lmao that's exactly what i was doing |
Fetch upstream
Sounds great! It might be useful to mention that the method mentioned in #207 by Figuera; for changing the background and foreground color is still possible. By adding this line: /usr/bin/printf "%b" "\e]P0{background-color}\e]P7{foreground-color}\ec" > /dev/"${TTY}" Best to place it either after CONFTTY or TTY and depending on which var; the var in place of the tty will need to be changed, of course. In this case I have placed it at the end of the script ( I really would've liked to use start_pre() for this, and frankly most of the stuff in this script, but that doesn't seem to work; despite start_pre() being in the documentation). This could also be placed in a different service script, if you wanted. |
Thanks this looks great!
My apologies I didn't see that. I have merged it. |
I would like the same thing but nullgemm has said that he doesn't plan on supporting that feature, #207. So it's more of a workaround. |
Merge MadcowOG's branch into master
One thing could be a good change is to move the installation of each service file to their own make functions (like with openrc atm). Because install always installs the systemd service file even if you are on openrc and will end up using installopenrc. It might require a little bit of work downstream but still might be worth it for long term compatibility with other inits. |
I made a make-services branch which contains a modified makefile and readme. Let me know if this seems good. |
@WNCRY Would you mind testing the latest script in this PR to confirm that it works on Gentoo? |
Also added tiny clarification of installing ly within install and installnoconf.
Independent install for each service, and documentation to accomodate.
@MadcowOG @Cavernosa Can this be merged? |
I think so. I don't have any new ideas and the script is working fine. |
Alright then! |
I tested and it doesn't seem to break anything
Closes #343 #295